Fix logging redudancy on multiple instances #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When making multiple trackers (or re-instantiating as common in Notebook-like environments), each instantiation of CarbonTracker causes logging to duplicate messages. This is due to logger.getLogging always returning the same logging instance when called with the same argument (singleton-like). This is fixed by having each instance of CarbonTracker have a unique logging_id, which makes each instance have their own logger. also including changes to logger
Snailed
force-pushed
the
fix-multiple-instantiations
branch
from
c06b3e1 to
2e1d3eb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When making multiple trackers (or re-instantiating as common in Notebook-like environments), each instantiation of CarbonTracker causes logging to duplicate messages. This is due to logger.getLogging always returning the same logging instance when called with the same argument (singleton-like). This is fixed by having each instance of CarbonTracker have a unique logging_id, which makes each instance have their own logger.
This solves issue #70