fix issue with scores plot by multiplying height, width with nrow, nc…

…ol, scales = 'free'
lgessl · Jan 19, 2024 · 5fcb360 · 5fcb360
1 parent b7ea2a2
commit 5fcb360
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/R/assess_model.R b/R/assess_model.R
@@ -89,6 +89,7 @@ assess_model <- function(
             predicted = prep[["predicted"]],
             actual = prep[["actual"]],
             perf_plot_spec = pps_scores,
+            ncol = model_spec$plot_ncols,
             msg_prefix = msg_prefix
         )
     }

diff --git a/R/assess_model_helpers.R b/R/assess_model_helpers.R
@@ -209,6 +209,11 @@ plot_risk_scores <- function(
     )
     tbl[["split"]] <- paste0("Split ", tbl[["split"]])
 
+    n_split <- sum(!sapply(predicted, is.null))
+    nrow <- ceiling(n_split/ncol)
+    perf_plot_spec$height <- nrow * perf_plot_spec$height
+    perf_plot_spec$width <- ncol * perf_plot_spec$width
+
     plt <- ggplot2::ggplot(
         tbl,
         ggplot2::aes(
@@ -219,7 +224,8 @@ plot_risk_scores <- function(
         ) +
         ggplot2::facet_wrap(
             facets = ggplot2::vars(.data[["split"]]),
-            ncol = ncol
+            ncol = ncol,
+            scales = "free"
         ) +
         ggplot2::geom_point() +
         ggplot2::labs(