Skip to content

Commit

Permalink
fix phpstan warning and php-cs-fixer
Browse files Browse the repository at this point in the history
  • Loading branch information
lhapaipai committed Oct 22, 2023
1 parent 9b989f6 commit 0ecb0d6
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,11 @@
"phpstan/phpstan": "^1.8"
},
"scripts": {
"cs-fix": "@php vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.dist.php",
"cs-fix": "php8.1 vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.dist.php",
"ci-check": [
"find -L . -path ./vendor -prune -o -type f -name '*.php' -print0 | xargs -0 -n 1 -P $(nproc) php -l",
"@php vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.dist.php --diff --dry-run --stop-on-violation --using-cache=no",
"@php vendor/bin/phpstan analyse --configuration=phpstan.neon"
"php8.1 vendor/bin/php-cs-fixer fix --config=.php-cs-fixer.dist.php --diff --dry-run --stop-on-violation --using-cache=no",
"php8.1 vendor/bin/phpstan analyse --configuration=phpstan.neon"
]
}
}
6 changes: 3 additions & 3 deletions src/Asset/TagRenderer.php
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ public function renderReactRefreshInline($devServerUrl): string
</script>'.PHP_EOL;
}

public function renderScriptFile($extraAttributes = [], $content = '', $buildName = null, $isBuild): string
public function renderScriptFile($extraAttributes = [], $content = '', $buildName = null, $isBuild = true): string
{
if (is_null($buildName)) {
$buildName = $this->defaultBuild;
Expand All @@ -82,7 +82,7 @@ public function renderScriptFile($extraAttributes = [], $content = '', $buildNam
return $this->renderTag('script', $event->getAttributes(), $content);
}

public function renderLinkStylesheet($fileName, $extraAttributes = [], $buildName = null, $isBuild): string
public function renderLinkStylesheet($fileName, $extraAttributes = [], $buildName = null, $isBuild = true): string
{
if (is_null($buildName)) {
$buildName = $this->defaultBuild;
Expand All @@ -105,7 +105,7 @@ public function renderLinkStylesheet($fileName, $extraAttributes = [], $buildNam
return $this->renderTag('link', $event->getAttributes());
}

public function renderLinkPreload($fileName, $extraAttributes = [], $buildName = null, $isBuild): string
public function renderLinkPreload($fileName, $extraAttributes = [], $buildName = null, $isBuild = true): string
{
if (is_null($buildName)) {
$buildName = $this->defaultBuild;
Expand Down

0 comments on commit 0ecb0d6

Please sign in to comment.