Comments.

libbitcoin · Aug 23, 2024 · 935bf7a · 935bf7a
1 parent 5ff7c3e
commit 935bf7a
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 0 deletions.
diff --git a/include/bitcoin/system/stream/streamers/byte_reader.hpp b/include/bitcoin/system/stream/streamers/byte_reader.hpp
@@ -121,6 +121,7 @@ class byte_reader
     /// -----------------------------------------------------------------------
     /// cptr/raw overrides return nullptr if reader is or becomes invalid.
     /// Non-null raw return must be destroyed using reader's allocator/arena.
+    /// Null raw return implies invalidated stream.
 
     /// Read all remaining bytes to chunk.
     data_chunk read_bytes() NOEXCEPT override;

diff --git a/src/chain/operation.cpp b/src/chain/operation.cpp
@@ -234,6 +234,8 @@ void operation::assign_data(reader& source) NOEXCEPT
     {
         code_ = any_invalid;
         source.set_position(start);
+
+        // An invalid source.read_bytes_raw returns nullptr.
         data_.reset(POINTER(data_chunk, allocator, source.read_bytes_raw()));
     }