mirror: Always disable unused CLI arguments warning for feature probe #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In commit 8a2d7d5 ("mirror: Fix features detection for building with clang") we prevented clang to error out when encountering unused command-line arguments in the feature probes, because we do add unused arguments for some of the probes when retrieving arguments from llvm-config, and we don't want probes to fail because of that. At the time, the issue was apparent for the LLVM-based disassembler, so we added -Wno-unused-command-line-argument when $(LLVM) was enabled, only. We missed the case when we're building bpftool with clang instead of gcc, without building the LLVM disassembler. Let's disable the warning unconditionally instead to fix this case. Reported-by: Holger Hoffstätte <[email protected]> Signed-off-by: Quentin Monnet <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In commit 8a2d7d5 ("mirror: Fix features detection for building with clang") we prevented clang to error out when encountering unused command-line arguments in the feature probes, because we do add unused arguments for some of the probes when retrieving arguments from llvm-config, and we don't want probes to fail because of that.
At the time, the issue was apparent for the LLVM-based disassembler, so we added -Wno-unused-command-line-argument when $(LLVM) was enabled, only. We missed the case when we're building bpftool with clang instead of gcc, without building the LLVM disassembler. Let's disable the warning unconditionally instead to fix this case.
Fixes: #170