Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
put
erfa_wrapp.py
andsetup.py
in the same directory whereerfa.c
anderfa.h
are, andthere is no check for there returned value, i'm working on it, when it's an integer; so be sure to pass correct value
functions that manipulate
char
,eraASTROM
anderaLDBODY
are skipped, for now.i added d2dtf manually. for this specific function, the only relevant string, according to the doc
is "utc". so there is no special need of a string argument here. for other functions with string, one may need a Python wrapper where one passes string argument. the corresponding c_ufunc must have fixed string.
there is still an issue with this function, on my platform, i have to cast the integer into int32:
same thing for other function using int
the script uses the doc to generate the wrapper, so it needs to be consistent and a careful check.
for example, there is a typo in the
eraCr
function and the generated wrapper cannot be computed.these functions are skipped.
when dealing with matrix and vector, they need to be flattened. that's not very practical.
a wrapper using structured array may be used here. i'll try to see if this is doable.
or maybe a Python wrapper to flatten the arguments and reshape the results.