This repository has been archived by the owner on May 14, 2020. It is now read-only.
Test all article list content #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thewilkybarkid
added
the
🚨 Tests
| expect(dataset).toBeRdfDatasetMatching({ subject: id, predicate: hydra.manages }); | ||
| expect(dataset).toBeRdfDatasetMatching({ subject: id, predicate: hydra.totalItems, object: toRdf(0) }); | ||
|
|
||
| const [{ object: manages }] = dataset.match(id, hydra.manages); |
There was a problem hiding this comment.
if the predicate is manages (namespaces notwithstanding), is the object manages too? Maybe managed?
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
assume if 2 articles suddenly come out the API, the [{...}] destructuring fails?
There was a problem hiding this comment.
oh wait, this only describes the type of the items, not their content
There was a problem hiding this comment.
It's assigning an alias to a property on an object that is the first item in the array. Complicated syntax...
Destructuring is fine if there's more than one, others are ignored.
giorgiosironi
approved these changes
Mar 13, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes sure that all quads in the article list are tested.
Found in #167.