Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds Depth to FetchOptions allowing for shallow cloning #2070

Merged

Conversation

andersklepaker
Copy link
Contributor

This PR adds Depth to FetchOptions allowing for shallow cloning.

Since I'm new to this repo and it's complexity it's possible i've missed some key information to why this have not been implemented, and if so I'm sorry for not reading up on it prior to submitting this PR.

Resolves #229

@fmargerit
Copy link

Hello, what's next for this pull request ?

@andersklepaker
Copy link
Contributor Author

Hello, what's next for this pull request ?

Someone needs to review and approve it I guess. Not sure if this is something @bording could do?

LibGit2Sharp/FetchOptions.cs Show resolved Hide resolved
LibGit2Sharp/Repository.cs Show resolved Hide resolved
LibGit2Sharp/Repository.cs Show resolved Hide resolved
@andersklepaker
Copy link
Contributor Author

@amirvenus Do you have write-access and can get this merged?

@goaaats
Copy link

goaaats commented May 26, 2024

Do the unresolved comments block this PR? If the original creator is not around to address them, would it be acceptable for someone else to take over and create a new PR?

@YanisThePie
Copy link

so what are the news about this PR?

@dcworldwide
Copy link

If practical or required, I'm available to help. Just LMK what I can do.

We are streaming git repo state across a distributed CD/CI system and shallow clones dramatically reduce our bandwidth needs.

@sureshkk
Copy link

Is there any updates on this PR?

@karlschriek
Copy link

Just to repeat @YanisThePie 's question from earlier. Are any of the comments on the PR actually blocking the merge? I think there may be some arguments that this could go through as it is. If a maintainer could provide feedback and clarify whether adjustments are needed that would be great. If indeed necessary I would be happy to open up a new PR if @andersklepaker is no longer dealing with this.

@andersklepaker
Copy link
Contributor Author

Thanks for the comments @karlschriek

If a maintainer could provide feedback and clarify whether adjustments are needed that would be great.

Yeah that would be great, and if so happens I'll finish up the work needed for this PR. I did not prioritize investing time here since this repo seems mostly inactive, sadly :(

@IEDAWHI
Copy link

IEDAWHI commented Sep 12, 2024

Are there any further updates? It would be greatly appreciated if this PR could be merged soon assuming there are no open comments or code changes required.

@YanisThePie
Copy link

YanisThePie commented Oct 29, 2024

Please, can someone do something about this forgotten PR?... @amirvenus could you merge this please?

@YanisThePie
Copy link

thanks @amirvenus for your approval! Are there still steps to go through before the PR is merge?

@PulsarFX
Copy link

@karlschriek I think this PR can now be completed? 🤞

@akirayamamoto
Copy link

@bording can you merge this PR?

@kristianbjensen
Copy link

Please merge. We have been missing this feature :)

@jhested
Copy link

jhested commented Nov 18, 2024

Would also appreciate if this can be merged

@gemolnar
Copy link

It would be great if this could be merged.

@YanisThePie
Copy link

Is this git repo still maintained?
11 month since the last update, and nobody to merge this PR since months...

@andersklepaker
Copy link
Contributor Author

This repo is still maintained even tho it is moving very slow. It's a open source project and we can't demand anything. Maintainers are free to do whatever they like, and that is totallly fine. But i'll admit that some kind of feedback from the maintainers would probably not hurt, as a few people have spent time on this PR.

@bording
Copy link
Member

bording commented Nov 20, 2024

Hey everyone. @andersklepaker gets to the heart of things. I'm pretty much the only one left who maintains this repo these days, and I just don't have much free time to devote to it.

This PR does seem to be one that a lot of people are asking for, so I'll try and review it soon.

@DominikKDev
Copy link

Thanks a lot @bording. This merge would enable some interesting scenarios, e.g. saving time and space fetching new repositories, so I'm looking forward to the review as well.

@bording bording merged commit 47b2ee0 into libgit2:master Nov 23, 2024
@bording
Copy link
Member

bording commented Nov 23, 2024

Thanks for the PR and thanks for your patience!

@YanisThePie
Copy link

@bording thanks for your hard work on this amazing project !
Now, What are the steps for the NuGet package to be updated and published with these changes?

@jhested
Copy link

jhested commented Nov 24, 2024

@bording Thank you so much for your hard work, I really appreciate it!

@gemolnar
Copy link

It was already a great library, and now it's even more useful. Thanks for all your effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Shallow clone support