Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert_almost_eq! #55

Merged
merged 15 commits into from
Nov 25, 2024
Merged

assert_almost_eq! #55

merged 15 commits into from
Nov 25, 2024

Conversation

mo271
Copy link
Member

@mo271 mo271 commented Nov 25, 2024

No description provided.

veluca93
veluca93 reviewed Nov 25, 2024
View reviewed changes
Copy link
Member

@veluca93 veluca93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't a new crate a bit overkill? Feels like a module in util/test.rs would be sufficient...

jxl_test_utils/src/lib.rs Outdated Show resolved Hide resolved
jxl_test_utils/src/lib.rs Outdated Show resolved Hide resolved
veluca93
veluca93 reviewed Nov 25, 2024
View reviewed changes
jxl/src/util/test.rs Outdated Show resolved Hide resolved
veluca93
veluca93 reviewed Nov 25, 2024
View reviewed changes
jxl/src/util/test.rs Outdated Show resolved Hide resolved
@mo271 mo271 requested a review from veluca93 November 25, 2024 13:25
veluca93
veluca93 reviewed Nov 25, 2024
View reviewed changes
jxl/src/util.rs Outdated Show resolved Hide resolved
veluca93
veluca93 reviewed Nov 25, 2024
View reviewed changes
jxl/src/util/test.rs Outdated Show resolved Hide resolved
@mo271 mo271 merged commit 10edd52 into libjxl:main Nov 25, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veluca93 veluca93 veluca93 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mo271 @veluca93