Fix junit_reporter XML output #91
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tim2000
commented
Mar 19, 2017
| @@ -30,6 +30,7 @@ | |||
| #include <limits> | |||
| #include <unordered_map> | |||
| #include <vector> | |||
| #include <utility> | |||
There was a problem hiding this comment.
std::pair is used inside the file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I came across this error during Jenkins JUnit integration of my benchmarks:
org.xml.sax.SAXParseException; systemId: file:/data/jenkins/jobs/CoreEngine-PT-Tests/builds/23/performance-reports/JUnit/perf_result.xml; lineNumber: 7; columnNumber: 4; The element type "property" must be terminated by the matching end-tag "".
This commit have fixed the issue.
You may not accept it since I have only tested it with JUnit Jenkins parser and it may not works with other parsers.