Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cherrypick] [23.10.3] PWX-35477 : Support Openshift Prometheus for portworx monitoring on OCP 4.14 #1412

Merged
merged 21 commits into from
Feb 1, 2024

Conversation

nikita-bhatia
Copy link
Contributor

Cherrypick #1410

@nikita-bhatia nikita-bhatia changed the title [Cherrtpick] [23.10.3] PWX-35477 : Support Openshift Prometheus for portworx monitoring on OCP 4.14 [Cherrypick] [23.10.3] PWX-35477 : Support Openshift Prometheus for portworx monitoring on OCP 4.14 Feb 1, 2024
Copy link

codecov bot commented Feb 1, 2024

Codecov Report

Attention: 52 lines in your changes are missing coverage. Please review.

Comparison is base (5b84a32) 79.82% compared to head (6b1a9cd) 79.69%.

Files Patch % Lines
drivers/storage/portworx/util/util.go 44.89% 23 Missing and 4 partials ⚠️
drivers/storage/portworx/component/autopilot.go 73.01% 9 Missing and 8 partials ⚠️
drivers/storage/portworx/portworx.go 46.66% 6 Missing and 2 partials ⚠️
Additional details and impacted files
@@                Coverage Diff                 @@
##           px-rel-23.10.3    #1412      +/-   ##
==================================================
- Coverage           79.82%   79.69%   -0.13%     
==================================================
  Files                  60       60              
  Lines               17517    17642     +125     
==================================================
+ Hits                13983    14060      +77     
- Misses               2557     2593      +36     
- Partials              977      989      +12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikita-bhatia nikita-bhatia merged commit a4ea1b8 into px-rel-23.10.3 Feb 1, 2024
3 of 5 checks passed
@nikita-bhatia nikita-bhatia deleted the PWX-35477_23.10.3 branch February 1, 2024 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants