Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OCP 4.14 : Fix Mount volume to autopilot pod only if secret is created #1415

Merged
merged 2 commits into from
Feb 2, 2024

Conversation

nikita-bhatia
Copy link
Contributor

What this PR does / why we need it: We should mount token and sertificates to autopilot pod only if autopilot-prometheus-auth secret is created, otherwise autopilot pod will start failing to come up and mounting error.

Extension of PR #1410

Copy link

codecov bot commented Feb 2, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (27e72d5) 75.87% compared to head (44201b2) 75.87%.

Files Patch % Lines
drivers/storage/portworx/component/autopilot.go 76.47% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1415      +/-   ##
==========================================
- Coverage   75.87%   75.87%   -0.01%     
==========================================
  Files          66       66              
  Lines       18965    18981      +16     
==========================================
+ Hits        14390    14402      +12     
- Misses       3549     3553       +4     
  Partials     1026     1026              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nikita-bhatia nikita-bhatia merged commit df505a7 into master Feb 2, 2024
7 of 8 checks passed
@nikita-bhatia nikita-bhatia deleted the ocp_prometheus branch February 2, 2024 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants