Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update browser example and remove webrtc-direct example #1751

Merged
merged 3 commits into from
May 12, 2023

Conversation

achingbrain
Copy link
Member

Add new transports to the browser example and remove the outdated webrtc-direct example as it uses a deprcated transport.

Refs: #1488

Add new transports to the browser example and remove the outdated
webrtc-direct example as it uses a deprcated transport.
@achingbrain achingbrain requested a review from maschad May 10, 2023 19:13
Copy link
Member

@maschad maschad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are some odd CI failures

- [@libp2p/websockets](https://github.com/libp2p/js-libp2p-websockets)
- [@libp2p/webtransport](https://github.com/libp2p/js-libp2p-webtransport) (Work in Progress)

If none of the available transports fulfills your needs, you can create a libp2p compatible transport. A libp2p transport just needs to be compliant with the [Transport Interface](https://github.com/libp2p/js-interfaces/tree/master/src/transport).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an official guideline on whether we use American or British English? I don't want any culture wars 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, force of habit.

@achingbrain achingbrain merged commit c90f496 into master May 12, 2023
@achingbrain achingbrain deleted the docs/update-webrtc-examples branch May 12, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants