fix: reduce TLS cert validity time #2457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`@peculiar/x509` may be representing everything as UTCTime - dates after 2050 should be GeneralizedTime so are rejected by compliant TLS implementations. Reduce the maximum validty of certificates to keep them under 2050 - this can be re-evaluated after PeculiarVentures/x509#73 is fixed.
Merged
achingbrain
added a commit
that referenced
this pull request
Apr 2, 2024
Partial revert of #2457. We can specify dates in the far future, causing `@peculiar/x509` to use `GeneralizedTime` values, but it doesn't strip fractional seconds as per RFC 5280 so do it ourselves.
3 tasks
achingbrain
added a commit
that referenced
this pull request
Apr 2, 2024
Partial revert of #2457. We can specify dates in the far future, causing `@peculiar/x509` to use `GeneralizedTime` values, but it doesn't strip fractional seconds as per RFC 5280 so do it ourselves.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@peculiar/x509cannot represent dates as far in advance as go-libp2p so the certs are rejected.Reduce the maximum validity of certificates to keep them under 2050 - this can be re-evaluated after PeculiarVentures/x509#73 is fixed.
Change checklist