fix: tls serial number causes illegal padding error #2459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a hack to work around PeculiarVentures/x509#74 until it is addressed upstream. It seems serial numbers starting with `80` cause `@peculiar/x509` to generate invalid certifiates that Node's `TLSSocket` then fails to parse, throwing an `ERR_OSSL_ASN1_ILLEGAL_PADDING` error, so the hack is to generate serial numbers until we get one that doesn't start with `80`. This can be reverted when the upstream issue is fixed.
|
I have been running connection tests with this patch against go-libp2p for 24 hours without a single error. |
maschad
approved these changes
Mar 31, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a hack to work around PeculiarVentures/x509#74 until it is addressed upstream.
It seems serial numbers starting with
80cause@peculiar/x509to generate invalid certifiates that Node'sTLSSocketthen fails to parse, throwing anERR_OSSL_ASN1_ILLEGAL_PADDINGerror, so the hack is to generate serial numbers until we get one that doesn't start with80.This can be reverted when the upstream issue is fixed.
Change checklist