ci: use workspace inheritance to enforce lints in all crates

[binsta]

Description

Starting with nightly-2023-09-10, the [lints] section in Cargo.toml files is stable. Together with workspace inheritance, this can be used to declare all lints we want to enforce in a single place.

Resolves: #4484.

Change checklist

• I have performed a self-review of my own code
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works
• A changelog entry has been made in the appropriate crates

[binsta]

@thomaseizinger Please take a look. If any changes are needed, please let me know. if the [lints] tag is in a stable release it will cool.

[thomaseizinger]

@thomaseizinger Please take a look. If any changes are needed, please let me know. if the [lints] tag is in a stable release it will cool.

Thanks for getting this started :)

[binsta]

@thomaseizinger I have a quick question on unreachable_pub. Running on cargo +nightly clippy

warning[E0602]: unknown lint: `clippy::unreachable_pub

Please check clippy::useless_attribute

[thomaseizinger]

@thomaseizinger I have a quick question on unreachable_pub. Running on cargo +nightly clippy

warning[E0602]: unknown lint: `clippy::unreachable_pub

Please check clippy::useless_attribute

That is because it is a rustc lint, not a clippy lint! I think you'll have to move it out of the clippy group in Cargo.toml :)

[mergify]

This pull request has merge conflicts. Could you please resolve them @binsta? 🙏

[thomaseizinger]

@binsta Once you've resolved the merge conflicts, CI can run again :)

[thomaseizinger]

@binsta Once you've resolved the merge conflicts, CI can run again :)

Btw, merging master is fine, we don't really do rebases here! See https://github.com/libp2p/rust-libp2p/blob/master/CONTRIBUTING.md#we-squash-merge-pull-requests.

[binsta]

@thomaseizinger Please review every conflict that has been resolved.

[binsta]

@binsta Once you've resolved the merge conflicts, CI can run again :)

Btw, merging master is fine, we don't really do rebases here! See https://github.com/libp2p/rust-libp2p/blob/master/CONTRIBUTING.md#we-squash-merge-pull-requests.

Thank you, Hereafter ill follow the same, methodology

[thomaseizinger]

@thomaseizinger Please review every conflict that has been resolved.

Thanks! They weren't quite resolved but I went ahead and fixed them for you :)

[thomaseizinger]

CI for clippy is passing which is nice! See https://github.com/libp2p/rust-libp2p/actions/runs/6386769096/job/17333995887?pr=4575.

I think we can merge this as is and simply swap out the clippy jobs again once this hits stable!

[binsta]

@thomaseizinger Please take a look

[thomaseizinger]

Thanks! This is good to go from my end :)

[thomaseizinger]

@libp2p/rust-libp2p-maintainers: Starting with this PR, you'll have to use nightly Rust for linting locally for a limited time. It is generally a good idea to use nightly Rust for local development because it helps detecting compiler bugs early. Our CI enforces that things work with stable anyway.

This feature is due to be stabilized in 1.74 I think hence I think it makes sense to already start using this. Once it is actually stable, we can switch CI back to running on the current stable and beta.

If there are no concerns, I'll merge this in the upcoming days.

[mergify]

This pull request has merge conflicts. Could you please resolve them @binsta? 🙏

[thomaseizinger]

@libp2p/rust-libp2p-maintainers: Starting with this PR, you'll have to use nightly Rust for linting locally for a limited time. It is generally a good idea to use nightly Rust for local development because it helps detecting compiler bugs early. Our CI enforces that things work with stable anyway.

This feature is due to be stabilized in 1.74 I think hence I think it makes sense to already start using this. Once it is actually stable, we can switch CI back to running on the current stable and beta.

If there are no concerns, I'll merge this in the upcoming days.

Most notably, nothing changes for users that are currently using stable rust and run cargo clippy. They'll still see a bunch of warning that are only ignored via our custom-clippy alias. To transition those, we could retain the alias for now but change it to run on a specific Rust toolchain, i.e. the nightly version that stabilizes the [lints] feature.

Or we just retain the alias altogether until [lints] stabilizes completely. We just need to manually keep it in sync until then but that shouldn't be too difficult given how rarely it changes.

[mxinden]

As discussed in our 1on1, feel free to go ahead here @thomaseizinger.

Approvals have been dismissed because the PR was updated after the send-it label was applied.

Approvals have been dismissed because the PR was updated after the send-it label was applied.