Reference experiment where needed, not simulation #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This appears to be the correct fix for libqueso#533; thanks to @briadam for tracking it down. This *doesn't* appear to change our regression results, however, which is a bit worrying...
Codecov Report
@@ Coverage Diff @@
## dev #554 +/- ##
=======================================
Coverage 69.44% 69.44%
=======================================
Files 170 170
Lines 14998 14998
=======================================
Hits 10416 10416
Misses 4582 4582
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This appears to be the correct fix for #533; thanks to @briadam for
tracking it down.
This doesn't appear to change our regression results, however, which
is a bit worrying...