Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lime-docs: update PKG_SOURCE_URL #1053

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

a-gave
Copy link
Contributor

@a-gave a-gave commented Sep 20, 2023

This update the PKG_SOURCE_URL and PKG_SOURCE_PROTO of lime-docs.
It seems something is changed from github.com's side:

  • the 'svn' proto is not accepted anymore (see logs)
  • while it is still present an http redirect from https://github.com/libremesh/lime-web/trunk/docs to https://github.com/libremesh/libremesh.github.io/

The bug is preventing v2023.1-rc2 to be build.
I made sure that this is the only bug that cause a build failure as now the build for v2023.1-rc2 is going on.

Error Details
SHELL= flock /home/antennine/openwrt_build/stable/libremesh_2023.1-rc2-ow22/openwrt_buildroot_22.03.5/tmp/.lime-docs-2023-09-17-1694972618.tar.xz.flock -c '  	 echo "Checking out files from the svn repository..."; mkdir -p /home/antennine/openwrt_build/stable/libremesh_2023.1-rc2-ow22/openwrt_buildroot_22.03.5/tmp/dl && cd /home/antennine/openwrt_build/stable/libremesh_2023.1-rc2-ow22/openwrt_buildroot_22.03.5/tmp/dl && rm -rf lime-docs-2023-09-17-1694972618 && [ \! -d lime-docs-2023-09-17-1694972618 ] && ( svn help export | grep -q trust-server-cert && svn export --non-interactive --trust-server-cert -rHEAD https://github.com/libremesh/lime-web/trunk/docs lime-docs-2023-09-17-1694972618 || svn export --non-interactive -rHEAD https://github.com/libremesh/lime-web/trunk/docs lime-docs-2023-09-17-1694972618 ) && echo "Packing checkout..." && export TAR_TIMESTAMP="" && tar --numeric-owner --owner=0 --group=0 --mode=a-s --sort=name ${TAR_TIMESTAMP:+--mtime="$TAR_TIMESTAMP"} -c lime-docs-2023-09-17-1694972618 | 	xz -zc -7e > /home/antennine/openwrt_build/stable/libremesh_2023.1-rc2-ow22/openwrt_buildroot_22.03.5/tmp/dl/lime-docs-2023-09-17-1694972618.tar.xz && mv /home/antennine/openwrt_build/stable/libremesh_2023.1-rc2-ow22/openwrt_buildroot_22.03.5/tmp/dl/lime-docs-2023-09-17-1694972618.tar.xz /home/antennine/openwrt_build/stable/libremesh_2023.1-rc2-ow22/openwrt_buildroot_22.03.5/dl/ && rm -rf lime-docs-2023-09-17-1694972618;     '
Checking out files from the svn repository...
/bin/sh: 1: svn: not found
/bin/sh: 1: svn: not found
make[3]: *** [Makefile:87: /home/antennine/openwrt_build/stable/libremesh_2023.1-rc2-ow22/openwrt_buildroot_22.03.5/dl/lime-docs-2023-09-17-1694972618.tar.xz] Error 127
make[3]: Leaving directory '/home/antennine/openwrt_build/stable/libremesh_2023.1-rc2-ow22/openwrt_buildroot_22.03.5/feeds/libremesh/packages/lime-docs'
time: package/feeds/libremesh/lime-docs/compile#0.12#0.03#0.13
    ERROR: package/feeds/libremesh/lime-docs failed to build.

@codecov-commenter
Copy link

Codecov Report

Merging #1053 (badf612) into master (bfb7e2f) will not change coverage.
The diff coverage is n/a.

❗ Current head badf612 differs from pull request most recent head 02673f0. Consider uploading reports for the commit 02673f0 to get more accurate results

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@           Coverage Diff           @@
##           master    #1053   +/-   ##
=======================================
  Coverage   79.65%   79.65%           
=======================================
  Files          53       53           
  Lines        4542     4542           
=======================================
  Hits         3618     3618           
  Misses        924      924           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ilario
Copy link
Member

ilario commented Sep 20, 2023

Can it be that you don't have SVN installed?
On my pc it still works:
svn checkout https://github.com/libremesh/lime-web/trunk/docs

I decided to use svn as git did not allow me to download only one folder of the repository.
But it is also ok to download the whole website with git and then copy to the router only the docs folder.

Did you try to compile with the proposed Makefile?
It is possible that you also need to change these lines replacing docs with libremesh.github.io/docs, but I did not check:

	$(INSTALL_DATA) $(PKG_BUILD_DIR)/docs/en_*.txt $(1)/www/docs/
[...]
	$(INSTALL_DATA) $(PKG_BUILD_DIR)/docs/it_*.txt $(1)/www/docs/

@a-gave
Copy link
Contributor Author

a-gave commented Sep 20, 2023

Can it be that you don't have SVN installed?
On my pc it still works:
svn checkout https://github.com/libremesh/lime-web/trunk/docs

I apologize svn wasn't installed. I'm closing it as you say svn downloads also less stuff.

@a-gave a-gave closed this Sep 20, 2023
@a-gave a-gave deleted the fix/lime-docs-update-source-url branch September 20, 2023 12:07
@ilario ilario mentioned this pull request Sep 20, 2023
@ilario
Copy link
Member

ilario commented Jan 10, 2024

@a-gave can you re-propose this change?

Now Github actually stopped offering the SVN access.

Thanks to @LaneaLucy for reporting this.

@a-gave a-gave restored the fix/lime-docs-update-source-url branch January 10, 2024 13:07
@a-gave a-gave reopened this Jan 10, 2024
@ilario ilario merged commit 5a50b6f into libremesh:master Jan 10, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants