Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependence altitude gain and throw amplitude of ailerons, elevator, rudder CC3D #67

Open
wants to merge 782 commits into
base: master
Choose a base branch
from

Conversation

kazmod1
Copy link

@kazmod1 kazmod1 commented May 18, 2022

Hello, I hope that this site is still at live and I can count on your help.
I have remark that changes in gain attitude (perhaps rate, other as well) influence throw of control surfaces . In my case
I'm using CC3D . What I can do to avoid this.
When gain is important throw of ailerons (other ) are large, but when gain is small the throws are as well small.

I like very much program Librepilot and I still using CC3D controller. Hope that I wrote correctly my pull.

Regards, K.Wirpszo

mindnever and others added 30 commits October 17, 2017 13:25
…rd files. Remove all manual settings objects initializations.
… it does already initialize ALL objects (not only settings) with UAVObjectsInitializeAll()
…uration, HomeLocation, RevoCalibration and TakeOffLocation
… instead of "pads" to match the user manual.
…h, but requiring at least one. Adjusted common option combobox sizes.
…l request #469)

Added Gentoo linux build instructions README

Approved-by: Philippe Renon <[email protected]>
Approved-by: Paul Jewell <[email protected]>
Approved-by: Lalanne Laurent <[email protected]>
Approved-by: Jan NIJS <[email protected]>
…atically (pull request #467)

LP-173 Initialize all settings objects automatically

Approved-by: Vladimir Zidar <[email protected]>
Approved-by: Philippe Renon <[email protected]>
Approved-by: Jan NIJS <[email protected]>
Approved-by: Lalanne Laurent <[email protected]>
osx: fix compilation error due to typo

Approved-by: Philippe Renon <[email protected]>
Approved-by: Lalanne Laurent <[email protected]>
Approved-by: Jan NIJS <[email protected]>
… request #473)

LP-544 Fix for ws2811 & servo driver conflict.

Approved-by: Vladimir Zidar <[email protected]>
Approved-by: Philippe Renon <[email protected]>
Approved-by: Jan NIJS <[email protected]>
Approved-by: Lalanne Laurent <[email protected]>
this is needed because TRUE/FALSE enum has been changed to True/False
but old TRUE/FALSE is used by templates
LP templates can be fixed but users' templates can't

logic is now to try case sensitive, if that fails try case insensitive
if case insensitive works, a warning is logged

a new warning is also logged if the enum can't be found at all
…s (pull request #455)

Add GCS Hardware pages for F3 boards

Approved-by: Mateusz Kaduk <[email protected]>
Approved-by: Vladimir Zidar <[email protected]>
Approved-by: Lalanne Laurent <[email protected]>
Approved-by: Philippe Renon <[email protected]>
f5soh and others added 26 commits February 16, 2019 14:17
LP-602 fix crashes, reboots and other problems with USB reconnects/replugs

Approved-by: Eric Price <[email protected]>
Approved-by: Alessio Morale <[email protected]>
Approved-by: Lalanne Laurent <[email protected]>
…l request #522)

LP-605 PathPlan 'Resume' Fix

Approved-by: Lalanne Laurent <[email protected]>
…525)

LP-606 Add missing setComboCurrentIndex

Approved-by: Lalanne Laurent <[email protected]>
Approved-by: Alessio Morale <[email protected]>
…ull request #521)

LP-604 Add a feed forward term to Stabilization outer loop

Approved-by: Eric Price <[email protected]>
Approved-by: Alessio Morale <[email protected]>
Approved-by: Lalanne Laurent <[email protected]>
…ll request #520)

LP-603 Make QUATERNION_STABILIZATION optional.

Approved-by: Lalanne Laurent <[email protected]>
…st #527)

LP-608 HoTT telemetry revonano

Approved-by: Vladimir Zidar <[email protected]>
Approved-by: Lalanne Laurent <[email protected]>
…t #526)

LP-607 Update to WMM-2015v2

Approved-by: Lalanne Laurent <[email protected]>
Approved-by: Alessio Morale <[email protected]>
… #517)

LP-601 Waypoint fixes

Approved-by: Lalanne Laurent <[email protected]>
Approved-by: Eric Price <[email protected]>
@paul-jewell
Copy link
Contributor

Hello, I hope that this site is still at live and I can count on your help. I have remark that changes in gain attitude (perhaps rate, other as well) influence throw of control surfaces . In my case I'm using CC3D . What I can do to avoid this. When gain is important throw of ailerons (other ) are large, but when gain is small the throws are as well small.

I like very much program Librepilot and I still using CC3D controller. Hope that I wrote correctly my pull.

Regards, K.Wirpszo

The main repo for development is on bitbucket, here: https://bitbucket.org/librepilot

I can't comment on your pull request as I haven't reviewed it, however I am sure your contribution will be welcomed! I recommend you head over and submit your PR there.

Best regards,
Paul

@theothercliff
Copy link
Contributor

theothercliff commented May 23, 2022

This looks like you are attempting to check in:
"[kazmod1] wants to merge 782 commits into [master] from [next]"
When I think about that... 782 commits. 😮 782 full sets of changes (multiple files for each one?) That doesn't sound correct to me.

I am far from a git guru 😄 and it has been a long time since I made a pull request (I read my notes when I need to do something like that), so given that...

That number 782 sounds like you are using 16.09 or something just a little later, and trying to put that on top of next. Or there is some other version / commit issue.

LibrePilot has only one branch and that is the tip of next (although I personally think it would be nice to see some backports to an updated 16.09 that is still compatible with the original 16.09, I do this for my own use). Generally, to check something in, you code and test it in your own pull of next (which currently is 16.09 + 796). When it is all working, you push it back to your own version of next which should be the current next plus your changes. You then do a pull request on that and after being voted to be OK (a non-trivial part, there are quite a few pull requests in this part of the process), someone with super privileges will merge it into the global next.

The description of this change sounds like it is fixing something that is working as it should? 😮 When you say "gain" I assume you mean PIDs. First of all, the Output page, min, neutral, max are adjusted for max throw without binding (also perhaps limited to some other limits like max recommended control deflection angles). That way, no matter what other configuration you change, it will never make the servos / surface move farther than that (but be aware that if it actually moves this far and hits the "stop" in flight that the PID is no longer working as it should and enters another form of wind-up / oscillation). Next, the definition of PIDs says that for a given error (like a bank angle that is not level but the sticks are centered), the higher the P term, the farther the ailerons (or whatever causes roll, that is differential motor thrust in multicopters) move. Of course the I term adds to that and winds it up slowly, farther and farther, till it hits I-Limit or Beta.

If you like, this could be discussed at forum.librepilot.org

@paul-jewell
Copy link
Contributor

@kazmod1: to add to Cliff's comment, more information about contributing to development can be found here: https://librepilot.atlassian.net/wiki/spaces/LPDOC/pages/84672528/Git+Workflow

You are definitely welcome to join the development team!

@kazmod1
Copy link
Author

kazmod1 commented May 24, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.