Convert speedtest.js, speedtest_worker.js to ES6 with JSDoc comments #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As far as I can see this would drop Internet Explorer support, right? |
|
Yes, it would break IE11 support. I'm also not familiar with the newer revisions of JavaScript so it would make it difficult for me to maintain. I appreciate your work but I can't merge this one yet |
|
Perfectly understood. |
SCG82
force-pushed
the
es6
branch
2 times, most recently
from
6fba89e
to
34c3991
Compare
|
Microsoft has pulled the plug on IE. This should no longer be an obstacle. |
|
@adolfintel Any interest in merging this (after conflicts are resolved)? |
|
@SCG82 I would be interested but I really need someone to maintain this project because I'm working full time and I don't have time to deal with something so large at the moment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.