Fix-dual-mode #679
Open
Fix-dual-mode #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coolhome
reviewed
Oct 29, 2024
| ] | ||
| ); | ||
| ?> | ||
| var SPEEDTEST_SERVERS= <?= json_encode($servers, JSON_PRETTY_PRINT) ?: '[]' ?>; | ||
| <?php } else { ?> |
There was a problem hiding this comment.
Curious why the new elseif block is important. If servers.json has all the possible servers including itself then I would assume we just need to remove $mode=="dual" and let it fall into the else below?
There was a problem hiding this comment.
The new block ensures that the current server is in the list of servers.
You can achieve the same manually by adding it to the json, but that's prone to errors.
In my interpretation "dual" mode means that it has the features from server.json plus the standalone local server.
alpine/debian docker image tests and fixes
… into fix-dual-mode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.