Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LIBRETRO: Update to ScummVM 2.1.0 #150

Merged
merged 8,501 commits into from
Nov 10, 2019

Conversation

RobLoach
Copy link

@RobLoach RobLoach commented Oct 15, 2019

This brings in the latest from v2.1.0 into the libretro core. It's currently missing an update to LibRetroFilesystemNode.

TODO

  • Update backends/fs/libretro/libretro-fs.h to the new spec
  • Update the libretro list of supported engines

@ccawley2011 Would you be willing to update LibRetroFilesystemNode to match the new AbstractFSNode?

criezy and others added 30 commits September 13, 2019 22:00
These were of the type memset of a complex structure.
These are from Henke37 via IRC.
…macOS

In that configuration it was missing the -liconv flag.
These were memcpy usage to copy a non-trivial structure.
These are replaced by Common::String usage.
Currently translated at 100.0% (1123 of 1123 strings)
This is replaced by simpler Common::String equivalent.
Currently translated at 100.0% (1123 of 1123 strings)
Currently translated at 100.0% (1123 of 1123 strings)
Currently translated at 82.6% (928 of 1123 strings)
Currently translated at 61.7% (693 of 1123 strings)
Currently translated at 87.6% (984 of 1123 strings)
@inactive123
Copy link

Looking forward to seeing this PR be completed. It will be awesome getting Blade Runner to finally run on ScummVM.

@ccawley2011
Copy link

I pushed some changes to this branch. Does this work for you?

@Darknior
Copy link

Darknior commented Nov 1, 2019

WOAW yes incredible, i really wish the LR ScummVM progress and become a real alternative to use on many devices :)

LIBRETRO: Update LibRetroFilsystemNode and engines
@RobLoach
Copy link
Author

RobLoach commented Nov 3, 2019

@ccawley2011 Thank you so much for the help! Tested this out, and was able to run monkey2 without any issues.

Screenshot at 2019-11-03 04-21-21

@RobLoach RobLoach changed the title LIBRETRO: Update to ScummVM 2.1.0 (WIP) LIBRETRO: Update to ScummVM 2.1.0 Nov 3, 2019
@RobLoach RobLoach mentioned this pull request Nov 3, 2019
@Darknior
Copy link

Darknior commented Nov 3, 2019

You really make a fantastic work !!!
Really <3
@RobLoach will you also try to move or copy some ScummVM option to the LR CORE menu to make them easy to use and save like all other core ?
Thanks

@RobLoach
Copy link
Author

RobLoach commented Nov 3, 2019

Made https://github.com/libretro/scummvm/issues/151 as a follow up issue. Great idea.

@hizzlekizzle
Copy link

@RobLoach is this one ready to merge?

@RobLoach
Copy link
Author

@hizzlekizzle This should be good to go, yes. Was able to save and load a game without issue.

@inactive123 inactive123 merged commit a063a1b into libretro-mirrors:master Nov 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.