Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix vector games not working and audio crackling #90

Closed
wants to merge 8 commits into from
Closed

Fix vector games not working and audio crackling #90

wants to merge 8 commits into from

Conversation

ghost
Copy link

@ghost ghost commented Jul 4, 2021

fixes #87
Also includes #86 for another segfault fix.
Also fixed the samplerate outrun starwars sound was crackling.
removed redundant libretro/config.c code that wasnt used

Things to note the rotated aspect ratio is wrong see mappy fshark its more of a stretch no biggie though. Also the vectors would be nicer looking with the vector options being set to optimal.

@ghost ghost mentioned this pull request Jul 4, 2021
@inactive123
Copy link
Contributor

Hi there @grant2258 ,

sorry for noticing this earlier. Can you fix the merge conflict? We could try finally getting this merged then.

@ghost
Copy link
Author

ghost commented Oct 10, 2021

I'll have a look when I can was a while ago will update when I've had a peek

@ghost
Copy link
Author

ghost commented Oct 10, 2021

The conflict is fixed please note tempest has some gfx issues, Im not sure where there problems happening but its a rotated vector game no idea if this is new or not as the vecor games werent working the none rotated ones are fine. It could also be a 64 bit issue will try hunt down whats happening in that particular game.

@ghost
Copy link
Author

ghost commented Oct 10, 2021

bars at the top

Screenshot from 2021-10-10 21-57-18

@ghost
Copy link
Author

ghost commented Oct 10, 2021

@twinaphex I did have this fixed it broke again with more commits. However the sample rate code will need worked if your putting optional sample rates in. 3000 was a sweet spot to work for everything without having to update the audio code. Ill wait till the everythign settles and redo the commit without the sound fix will leave it to at the latest pull request witch is broke. Will leave it up to the op to decide what to do with it.

@ghost
Copy link
Author

ghost commented Oct 10, 2021

@twinaphex add this pull request #86. Ill do another pull request once eveything is settled this is an important one for segfaults this commit did cover this but will be redone.

@ghost
Copy link
Author

ghost commented Oct 11, 2021

closing this for now will send a new one once the other pull request is in master

@ghost ghost closed this Oct 11, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Segfault in asteroid.zip
1 participant