This repository has been archived by the owner on Oct 18, 2023. It is now read-only.
Cleanup S3 bucket after bottomless test #565
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Horusiath
reviewed
Jul 31, 2023
neubaner
force-pushed
the
cleanup_s3_bucket_bottomless_test
branch
from
4552300 to
7651881
Compare
neubaner
force-pushed
the
cleanup_s3_bucket_bottomless_test
branch
from
7651881 to
b25fbe9
Compare
Horusiath
approved these changes
Aug 4, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we cannot rely on
S3BucketCleaner's drop guard to cleanup the S3 bucket after the test execution, I moved the cleanup into a function that takes aFutureinstead.Also changed the bottomless options to use S3_URL instead of relying on configured environment variables.