Corion/exporter inheritance #155
Conversation
This might break some arcane usages like HTTP::Status->import_to_level() that weren't documented usage anyway
The "our" syntax requires 5.6 anyway
|
@Corion Can you update diff --git a/Changes b/Changes
index db255951..167535a3 100644
--- a/Changes
+++ b/Changes
@@ -1,6 +1,7 @@
Revision history for HTTP-Message
{{$NEXT}}
+ - (Your change entry goes here)
6.29 2021-03-06 04:50:34Z
- fix issue with HTTP::Request internal cache for canonical url when using |
|
I've also updated the Changes file with the two changes |
| @@ -5,7 +5,7 @@ use warnings; | |||
|
|
|||
| our $VERSION = '6.30'; | |||
|
|
|||
| use base 'Exporter'; | |||
| use Exporter 5.57 'import'; | |||
There was a problem hiding this comment.
Just a style question here. I know in our other LWP things we tend to:
use Foo::Bar qw(thing_to_import);https://github.com/libwww-perl/libwww-perl/blob/master/lib/LWP/UserAgent.pm#L16 for example.
Since we already have the version required for Exporter in our build, should this instead be
use Exporter qw(import);
There was a problem hiding this comment.
Right, that would be in line with other uses. I can occasionally run https://metacpan.org/pod/perlimports on the repo to enforce style. That will rewrite imports. It will preserve the version number, though.
|
The build test failure is what was reported in #101. There's a fix in that issue that we could apply. |
|
This search for |
|
New version released, thanks @Corion! |
This patch does two things:
This might break usage like
The use of
ourrequires Perl 5.6 anyway