-
-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only clone repos necessary for selected services #13
Conversation
…fusion when users fork
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From a fresh checkout of this PR (with an empty repo
directory), I'm seeing an issue where empty directories are being created for services that I did not select. For example, I selected "Berserk" as the only optional service I wanted:
And it mentioned in the output the 5 repos that were necessary to clone. However, in my repos
directory I have the following that were created:
In this instance, it additionally created all of the directories in the screenshot above owned by root
, but they are empty.
This is problematic, because the next time I run ./lila-docker down
, followed by a start
and let's say I want to select the scalachess
service this time around, I won't be able to as the directory already exists (and is owned by root):
Thanks for testing! I will work on addressing this. It's creating those empty folders because they are the volumes defined for the containers in When I tested, it wasn't an issue because on both my Mac and Linux machines, it creates them as my user (not root). So next time I do a |
Pushed 2 commits to fix. The first did it in bash but the Rust command had to communicate which dirs to create, so I had to create a new .env var. The second changes that behavior and mounts the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reverts commit 4e89def.
I tried it in gitpod and got that error too. Just reverted the 2nd commit and went back to creating it in bash. Now it creates them with the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested and it's now working for me as well.
Faster startup times for gitpod workspaces + prevents cloning unnecessary repos