Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Prometheus exporter #625

Merged
merged 2 commits into from
Dec 1, 2024

Conversation

lenguyenthanh
Copy link
Member

@lenguyenthanh lenguyenthanh commented Dec 1, 2024

Follow up: lichess-org/lila#16500,

need to update applicaton.conf:

-    prometheus-reporter.enabled = yes
+    prometheus-reporter {
+      enabled = yes
+      factory = "lila.ws.PrometheusReporter$Factory"
+    }

tested locally

@ornicar
Copy link
Collaborator

ornicar commented Dec 1, 2024

shouldn't that go to a scalalib subproject instead?

@lenguyenthanh
Copy link
Member Author

lenguyenthanh commented Dec 1, 2024

I don't think this is something we should maintain in the long term. It's (hopefully) a temporary single file, which can be removed after kamon fixing the issue.

Moving this to scalalib is a bit overkill unnecessary , I think.

@ornicar
Copy link
Collaborator

ornicar commented Dec 1, 2024

we'll see how well that comment ages.

@ornicar ornicar merged commit 1643ba1 into lichess-org:master Dec 1, 2024
1 check passed
@lenguyenthanh lenguyenthanh deleted the prometheus-exporter branch December 1, 2024 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants