remove redundant function

lichess-org · Nov 13, 2024 · 498f5c9 · 498f5c9
1 parent 208d12d
commit 498f5c9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/ui/chess/src/moveRootCtrl.ts b/ui/chess/src/moveRootCtrl.ts
@@ -12,7 +12,7 @@ export interface MoveRootCtrl {
   blindfold?: (v?: boolean) => boolean;
   speakClock?: () => void;
   goBerserk?: () => void;
-  shouldConfirmMove?: () => boolean;
+  confirmMoveToggle?: () => boolean;
 }
 
 export interface MoveUpdate {

diff --git a/ui/round/src/ctrl.ts b/ui/round/src/ctrl.ts
@@ -334,16 +334,13 @@ export default class RoundController implements MoveRootCtrl {
     this.keyboardMove?.update({ fen, canMove: this.canMove() });
   };
 
-  shouldConfirmMove = (): boolean =>
-    (this.data.pref.submitMove && this.confirmMoveToggle()) || this.confirmMoveToggle();
-
   sendMove = (orig: Key, dest: Key, prom: Role | undefined, meta: MoveMetadata): void => {
     const move: SocketMove = { u: orig + dest };
     if (prom) move.u += prom === 'knight' ? 'n' : prom[0];
     if (blur.get()) move.b = 1;
     this.resign(false);
 
-    if (!meta.preConfirmed && this.shouldConfirmMove() && !meta.premove) {
+    if (!meta.preConfirmed && this.confirmMoveToggle() && !meta.premove) {
       if (site.sound.speech()) {
         const spoken = `${speakable(sanOf(readFen(this.stepAt(this.ply).fen), move.u))}. confirm?`;
         site.sound.say(spoken, false, true);
@@ -359,7 +356,7 @@ export default class RoundController implements MoveRootCtrl {
     const drop: SocketDrop = { role, pos: key };
     if (blur.get()) drop.b = 1;
     this.resign(false);
-    if (this.shouldConfirmMove() && !isPredrop) {
+    if (this.confirmMoveToggle() && !isPredrop) {
       this.toSubmit = drop;
       this.redraw();
     } else {

diff --git a/ui/voice/src/move/voice.move.ts b/ui/voice/src/move/voice.move.ts
@@ -297,7 +297,7 @@ export function initModule({
     // trim choices to clarity window
     options = options.filter(([, m]) => m.cost - lowestCost <= clarityThreshold);
 
-    if (!timer() && options.length === 1 && (options[0][1].cost < 0.3 || root.shouldConfirmMove?.())) {
+    if (!timer() && options.length === 1 && (options[0][1].cost < 0.3 || root.confirmMoveToggle?.())) {
       console.info('chooseMoves', `chose '${options[0][0]}' cost=${options[0][1].cost}`);
       submit(options[0][0], false);
       return true;