memoized ui/common device.isApple, compute device.shareIcon when needed

lichess-org · Nov 17, 2024 · ab14fa8 · ab14fa8
1 parent bfa44ab
commit ab14fa8
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/ui/analyse/src/study/studyView.ts b/ui/analyse/src/study/studyView.ts
@@ -109,7 +109,7 @@ function buttons(root: AnalyseCtrl): VNode {
           count: root.data.analysis && '✓',
         }),
       toolButton({ ctrl, tab: 'multiBoard', hint: 'Multiboard', icon: iconTag(licon.Multiboard) }),
-      toolButton({ ctrl, tab: 'share', hint: i18n.study.shareAndExport, icon: iconTag(shareIcon) }),
+      toolButton({ ctrl, tab: 'share', hint: i18n.study.shareAndExport, icon: iconTag(shareIcon()) }),
       !ctrl.relay &&
         !ctrl.data.chapter.gamebook &&
         h('span.help', {

diff --git a/ui/common/src/device.ts b/ui/common/src/device.ts
@@ -93,9 +93,11 @@ export const isSafari = (): boolean => /^((?!chrome|android).)*safari/i.test(nav
 
 export const isIOSChrome = (): boolean => /CriOS/.test(navigator.userAgent);
 
-export const shareIcon: string = /Macintosh|iPhone|iPad|iPod/.test(navigator.userAgent) // macOS or iOS
-  ? licon.ShareIos
-  : licon.ShareAndroid;
+export const isApple: () => boolean = memoize<boolean>(
+  () => /Macintosh|iPhone|iPad|iPod/.test(navigator.userAgent), // macOS or iOS
+);
+
+export const shareIcon: () => string = () => (isApple() ? licon.ShareIos : licon.ShareAndroid);
 
 export type Feature = 'wasm' | 'sharedMem' | 'simd';