Use scss for hiding the side UI rating in game

lichess-org · Dec 15, 2024 · e41563b · e41563b
1 parent 178eee1
commit e41563b
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/modules/round/src/main/JsonView.scala b/modules/round/src/main/JsonView.scala
@@ -116,7 +116,6 @@ final class JsonView(
             .add("confirmResign" -> (!flags.nvui && pref.confirmResign == Pref.ConfirmResign.YES))
             .add("keyboardMove" -> (!flags.nvui && pref.hasKeyboardMove))
             .add("voiceMove" -> (!flags.nvui && pref.hasVoice))
-            .add("hideRatingsInGame" -> pref.hideRatingsInGame)
             .add("rookCastle" -> (pref.rookCastle == Pref.RookCastle.YES))
             .add("highlight" -> pref.highlight)
             .add("destination" -> pref.destination)

diff --git a/ui/round/css/_user.scss b/ui/round/css/_user.scss
@@ -26,6 +26,9 @@
     margin: 0 0.25em 0 0.3em;
     color: $c-font-dim;
     letter-spacing: -0.5px;
+    body.no-rating & {
+      display: none;
+    }
   }
 
   .line {

diff --git a/ui/round/src/interfaces.ts b/ui/round/src/interfaces.ts
@@ -187,7 +187,6 @@ export interface Pref {
   highlight: boolean;
   is3d: boolean;
   keyboardMove: boolean;
-  hideRatingsInGame: boolean;
   voiceMove: boolean;
   moveEvent: Prefs.MoveEvent;
   ratings: boolean;

diff --git a/ui/round/src/view/user.ts b/ui/round/src/view/user.ts
@@ -10,7 +10,6 @@ export function userHtml(ctrl: RoundController, player: Player, position: Positi
     user = player.user,
     perf = (user?.perfs || {})[d.game.perf],
     rating = player.rating || perf?.rating,
-    showRating = d.pref.hideRatingsInGame ? !ctrl.isPlaying() : !!rating,
     signal = user?.id === d.opponent.user?.id ? d.opponentSignal : undefined;
 
   if (user) {
@@ -43,7 +42,7 @@ export function userHtml(ctrl: RoundController, player: Player, position: Positi
           line: false,
         }),
         !!signal && signalBars(signal),
-        showRating && h('rating', rating + (player.provisional ? '?' : '')),
+        !!rating && h('rating', rating + (player.provisional ? '?' : '')),
         !!rating && ratingDiff(player),
         player.engine &&
           h('span', {