Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move classification flairs (fixes #14264 ) #14265

Merged
merged 12 commits into from
Dec 23, 2023

Conversation

TheForkPower
Copy link
Contributor

Screenshot 2023-12-21 at 14 23 38 People are using the above as move classifications. Going to add some move classification flairs soon (coloured) Mockup: Screenshot 2023-12-21 at 15 10 03

roboto 60x60 to align with theme

@TheForkPower TheForkPower changed the title Move classification flairs (#14264) Move classification flairs (fixes #14264) Dec 21, 2023
@TheForkPower TheForkPower changed the title Move classification flairs (fixes #14264) Move classification flairs (fixes 14264) Dec 21, 2023
@TheForkPower TheForkPower changed the title Move classification flairs (fixes 14264) Move classification flairs (fixes #14264) Dec 21, 2023
@TheForkPower TheForkPower changed the title Move classification flairs (fixes #14264) Move classification flairs (fixes #14264 ) Dec 21, 2023
@M-DinhHoangViet
Copy link
Contributor

Why don't you put them in 1 single commit?

@cmgchess
Copy link
Contributor

Why don't you put them in 1 single commit?

actually, it doesn't matter if it is a single commit or multiple commits. the person who has merging capabilities can decide if all the commits be squashed into 1 and merged or not :)

@ornicar ornicar merged commit 51e0256 into lichess-org:master Dec 23, 2023
4 checks passed
ornicar added a commit to ross39/lila that referenced this pull request Dec 23, 2023
* master: (206 commits)
  fix /video 404 page - closes lichess-org#14262
  Move classification flairs (fixes lichess-org#14264 ) (lichess-org#14265)
  add puzzle theme translation keys to the streak page - closes lichess-org#14273
  fix ui storage must remove the birthday key on expiration
  rename and factor ui storage birthday key
  New Crowdin updates (lichess-org#14271)
  hard coded ttl always
  remove unused function
  persistent log ws failures
  switch from xz to zstd for artifacts
  fix deploy after artifacts v4 update
  update to potentially much faster upload-artifact v4
  scala tweak, use form3.submit
  remove code duplication in ublog post ranking
  make it a bit clearer which fields are required when recomputing upost rank
  fix ublog post ranking when there is no rankAdjustDays
  don't confuse user with mod in mod log
  simplify using post.created.by
  tweak default broadcast pull periods
  recover from missing broadcast game using index.json metadata - closes lichess-org#14270
  ...
ornicar added a commit to M-DinhHoangViet/lila that referenced this pull request Dec 23, 2023
* master: (43 commits)
  simplify and redesign challenge page QR code
  fix /video 404 page - closes lichess-org#14262
  Move classification flairs (fixes lichess-org#14264 ) (lichess-org#14265)
  add puzzle theme translation keys to the streak page - closes lichess-org#14273
  fix ui storage must remove the birthday key on expiration
  rename and factor ui storage birthday key
  New Crowdin updates (lichess-org#14271)
  hard coded ttl always
  remove unused function
  persistent log ws failures
  switch from xz to zstd for artifacts
  fix deploy after artifacts v4 update
  update to potentially much faster upload-artifact v4
  scala tweak, use form3.submit
  remove code duplication in ublog post ranking
  make it a bit clearer which fields are required when recomputing upost rank
  fix ublog post ranking when there is no rankAdjustDays
  don't confuse user with mod in mod log
  simplify using post.created.by
  tweak default broadcast pull periods
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants