Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Practice with computer" defaults the player to white (and computer to black) in Racing Kings games #14116 #14820

Closed
wants to merge 6 commits into from
Closed

"Practice with computer" defaults the player to white (and computer to black) in Racing Kings games #14116 #14820

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
be6d686
made fix
GideonPotok Mar 6, 2024
2f1d5f4
Update ui/analyse/src/practice/practiceCtrl.ts
GideonPotok Mar 6, 2024
6efc69b
Made the change have less of a blast radius.
GideonPotok Mar 7, 2024
62557ef
pnpm format
GideonPotok Mar 7, 2024
d0eaa1a
use ternary operator
GideonPotok Mar 7, 2024
b0745cf
made playerColor Dependent on orientation (but the default orientatio…
GideonPotok Mar 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ui/analyse/src/ctrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,6 +277,10 @@ export default class AnalyseCtrl {
return opposite(this.bottomColor());
}

playerColor(): Color {
return this.flipped ? opposite(this.data.game.player) : this.data.game.player;
}

bottomColor(): Color {
if (this.data.game.variant.key === 'racingKings') return this.flipped ? 'black' : 'white';
return this.flipped ? opposite(this.data.orientation) : this.data.orientation;
Expand Down
5 changes: 4 additions & 1 deletion ui/analyse/src/practice/practiceCtrl.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,10 @@ export function make(root: AnalyseCtrl, playableDepth: () => number): PracticeCt
}

function isMyTurn(): boolean {
return root.turnColor() === root.bottomColor();
return (
root.turnColor() ===
(root.data.game.variant.key === 'racingKings' ? root.playerColor() : root.bottomColor())
);
}

function checkCeval() {
Expand Down
Loading