Make DGT board Play Menu shortcut configurable #15044
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the possibility to configure the inclusion or exclusion of the "DGT board" play menu entry, via the /dgt/configure page. Before, the "DGT board" entry would be automatically added to the menu upon generating a token (`/dgt/config/token`) and/or playing (`/dgt/play`), and there was no way to remove it.
|
I suspect there exists a more clever way to toggle/remove the DGT board play meny shortcut, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If one has played with DGT board,
there's a "DGT board" entry added to the topnav Play menu.
It isn't possible to remove this entry.
This Pull Request makes it possible to configure if the entry should be available or not.
Maybe there are many ways to implement this feature,
and maybe simpler ways than this one... But this was what I first thought of,
and found it interesting to try to implement - and at least it seems to perform the job...
dgt-board-menu-shortcut.webm
Became aware of this issue via Lichess Feedback post,
and noticed I had the menu entry too, from reproducing and fixing another bug with DGT. 😅
Note, this Pull Request also includes the commit from Pull Request #15043 - not sure if there are any good ways to handle Pull Requests which depend on eachother in GitHub...