Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uppercase second word in "Puzzle themes" menu-item #15801

Merged

Conversation

bastianpedersen
Copy link
Contributor

Closes #15659.

This is done to align with the other menu-items having all their first letter uppercased in all words. I have done the necessary change in Crowdin as well I think?

CleanShot 2024-07-28 at 11 13 59

@SergioGlorias
Copy link
Member

I have done the necessary change in Crowdin as well I think?

You only edited in English, the issue is that translators from other languages ​​will not be notified to correct the issue.

@bastianpedersen
Copy link
Contributor Author

I have done the necessary change in Crowdin as well I think?

You only edited in English, the issue is that translators from other languages ​​will not be notified to correct the issue.

Yeah, that was my concern. This is my first time doing changes in Crowdin, so I was not sure about how I should go about it.

@ornicar ornicar merged commit 43c3424 into lichess-org:master Jul 29, 2024
5 checks passed
@bastianpedersen bastianpedersen deleted the align-puzzles-menu-casing branch July 29, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Uppercase "T" in "Puzzle themes" menu-dropdown item
3 participants