Add "checkmate" sound to robot voice #16220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- resolves issue lichess-org#12004 - Previous robot sound commit didn't mention the voice used. So I used [coqui-ai/TTS](https://github.com/coqui-ai/TTS) - The voice comes from `tacotron2` - Can be generated with the command: `tts --model_name "tts_models/en/ljspeech/tacotron2-DDC" --text "Checkmate"` - Other non "robot" sounds have symlinks made from "Check.mp3/ogg" to "Checkmate.mp3/ogg", following the practice seen in lichess-org#594 Signed-off-by: Zinkelburger <[email protected]>
Zinkelburger
force-pushed
the
add_checkmate_sound
branch
from
a96dfa4 to
f4d2e47
Compare
|
It now says "victory" and "checkmate" at the same time. Not sure which one should have prefrence, or if both should be played with one delayed. But we probably don't want the sounds to overlap. |
|
Oh I see. I was only testing in the analysis board, not in a game. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello.
Previously the Robot voice was only able to say 'check', which was a little jarring.
Due to no signs of how the previous robot sound was generated, I used coqui-ai/TTS
tacotron2.The mp3 and ogg were generated from
ffmpeg, not sure if they need some special compression.To accommodate the new checkmate sound, I made symlinks in the sounds from "Check.mp3/ogg" → "Checkmate.mp3/ogg.
This follows the idea "Missing sounds are replaced with a symlink to another sound" which was suggested in #594.
I didn't regenerate the "Check" sound for robot, because although
tacotron2sounds great onCheckmate, itsCheckhad a click I didn't like. The other models I tried sound better onCheck, but worse onCheckmate. I can find a new model if its important to have the same voice.Its likely I made some errors in the code, but the new sound does work in my dev environment.
Resolves issue #12004