use javascript assets for client i18n #16223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i figured out why the green "additions" count is so high. remove i18n.d.ts from this PR (which is generated and has 5000+ lines), then this happens: 1251 fewer lines in scala sources compared to master |
ornicar
added a commit
that referenced
this pull request
Oct 18, 2024
ornicar
added a commit
that referenced
this pull request
Oct 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build will generate, watch, etc all needed sources in normal operation.
ui/build --cleanwill deep clean, removing alltranslation/js/*and the@types/lichess/i18n.d.tsfile. Deep clean shouldn't be necessary.This removes a lot more code than it adds despite git's notion of additions & deletions.