Add possibility to hide user's and opponent's ratings ONLY when playing

[yahya-lafhal]

Resolves #15632

I added a new game behavior preference that lets the user decide whether to show or not his rating and his opponent's rating while he is in game. Once the game is ended, the ratings are showed again. This lets users have both the possibility to see ratings throughout the website (analysis, watching games, challenges, profiles, ...) and the possibility to focus while playing without seeing and thinking of the ratings.

What can be added : Translations for other languages for the new preference

[trevorbayless]

I checked out the PR and tested the changes. Below are some findings I wanted to capture for notice and consideration for you and other reviewers.

• If this preference is enabled and and you are sent a challenge, the rating is still displayed on the challenge popup which spoils the opponents rating before possibly accepting:
  

• Same issue as above but on the "Play with a friend" challenge link:
  

• There is a placeholder gap on the powertip popup which shows user ratings which I recommend cleaning up (the existing hide ratings feature already does this, so I recommend looking at how it does that):
  
  

• This new setting "Show player ratings while playing your games" is similar to the existing setting "Show player ratings" but it's under a different preference screen ("Preferences -> Game Behavior" vs "Preferences -> Display").

• To me, it would make sense for these two rating settings to be combined (how Zen mode is) since you will only ever have one of these settings activated at a given time:
  
  
  example:
  

[yahya-lafhal]

Totally right thanks for the review, I will work on these changes when I have time :)

I'm just not sure if the challenges and "Play with a friend" can confuse users because they are not in-game yet so I don't really know if we should or not hide the ratings there.

[ornicar]

ratings are still visible when hovering the crosstable games

[ornicar]

all user tooltips have a large unused space when using the new setting

[yahya-lafhal]

For the user tooltips space problem, it is when checking one outside of the game page, so most likely not the opponent's one. Should I fix the space or let the user see the ratings on the user tooltips of users that are not him or his current opponent while he is in game ? I am still not sure what ratings we should and shouldn't hide for this feature.

Same thing for the crosstable games, it's old games and old ratings, knowing that we already show the opponent rating once the game ends, should I hide it or let it ?

[ornicar]

1. I think we should be able to see all ratings normally outside of the current game page.
2. The crosstable games are on the current game page, so they shouldn't reveal ratings.

[yahya-lafhal]

Perfect, I'll work on it !

[yahya-lafhal]

I made the crosstable games not reveal the ratings anymore. It works fine now. But I'm struggling a bit with showing the ratings outside the current game page. It hides the ratings in two places : the users minis and the games minis. So if you are currently in game, even if you leave the game page, you are not able to check another user's rating via his mini (in the homepage etc). I don't really know how to make it depend on the current page. I thought about the "playing" or "no-rating" classes that are set on the html body, but I think it's a weird approach. And even with that, it doesn't remove the classes in the game page directly after ending, it requires a refresh. Let me know if you have an idea or opinion about how to deal with this.

[ornicar]

I see that the current implementation relies on env.round.playing. This only works for realtime games; not for correspondence games.
Indeed we can't consider that someone is currently playing, just because they have an ongoing correspondence game, which can last months.

As a result I think the current implementation cannot work.

Instead it should probably rely on CSS-only tweaks, using the body.playing.no-rating selector.

[yahya-lafhal]

Back to this after my exams haha. So as discussed, I replaced the logic relying on env.round.playing with a css logic around the no-rating body class. It works great as expected. The only thing is that after ending a game, it doesn't show the rating directly, the user has to either refresh or go to another page like the review etc. But I think it makes sense in case the user wants to rematch without seeing the opponent rating. So to me it's even better. Let me know if I should change or add anything.

[ornicar]

Nice and simple, I like it