always request webp from picfit #16231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah sorry I didn't follow up on that. If the stored format isn't the same as the one requested, I guess picfit only convert it once and then store the conversion as well? |
|
I am actually not sure about that, but we're using picfit through the CDN, so there's caching at least at that layer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Afaict we already use webp without fallback for a couple of things (flairs, backgrounds). We could also ask picfit to deliver all images as webp. Thoughts?
Alternatively, adding fallbacks using
<picture>seems pretty straight forward.cc @kraktus, cc @schlawg