Fix nav flicker that happens on window resize #16232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trevorbayless
force-pushed
the
hbg_menu_flicker
branch
from
b449fc2 to
b618c7a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the navigation hamburger menu flicker that happens on window resize. The issue is
transition: transform 200ms;always being applied when the layout changes. Changed to add the transition selectively when the menu is opened/closed.The approach in this PR keeps all transitions as is. The new
openedclass cannot be simplytoggledas we need to wait long enough for the transition to finish (for the close transition), hence thesetTimeoutcall on menu close. I felt this was the most straightforward approach that maintains compatibility as listening to when atransitionedevent completes seems to be browser specific.Solves the problem seen here:
2024-10-16.15-50-28.mp4