Move a student to another class #16593
Merged
+83
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ornicar
force-pushed
the
class-move-student
branch
from
247dadf to
f56652d
Compare
ornicar
reviewed
Dec 18, 2024
| @@ -217,6 +217,13 @@ final class StudentFormUi(helpers: Helpers, clasUi: ClasUi, studentUi: StudentUi | |||
| cls := "button button-empty button-red", | |||
| title := trans.clas.closeDesc1.txt() | |||
| )(trans.clas.closeStudent()) | |||
| ), | |||
| (!s.student.managed).option( | |||
There was a problem hiding this comment.
I coded the move for the managed student first and then I realized it was making sense for the non managed student too.
The views of managed and non managed students are a bit different.
When you click on a managed student in the list, you see 2 sets of actions
When you click on a non managed student you only have the first one
So I had a choice:
- Overloading the first set of actions with the move (keeping consistency between the 2 types of students)
- Do it one click later for the non managed in the edit form (but hiding it for the managed student because it was useless then)
So if you have a strong opinion about where it should be for this PR, I am happy to adapt.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR starts addressing a concern expressed in this issue #16562
Before starting to search for the best solution to perform batch moves, there is a need for a 'move student' feature
Moving a student means:
UX:
I'm looking forward to your feedback