Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: linea bridge balance mismatch moved to l2-bridge-linea #525

Merged
merged 6 commits into from
Apr 10, 2024
Merged

feat: linea bridge balance mismatch moved to l2-bridge-linea #525

merged 6 commits into from
Apr 10, 2024

Conversation

sergeyWh1te
Copy link
Contributor

@sergeyWh1te sergeyWh1te commented Apr 10, 2024 •
edited
Loading

Part of #526

@sergeyWh1te sergeyWh1te requested a review from a team as a code owner April 10, 2024 11:34
@sergeyWh1te sergeyWh1te force-pushed the linea-bridge-balance-mismatch branch from eca6e4d to 8d97a55 Compare April 10, 2024 11:36
@sergeyWh1te sergeyWh1te requested a review from a team as a code owner April 10, 2024 11:36
@sergeyWh1te sergeyWh1te mentioned this pull request Apr 10, 2024
Open
6 tasks
@sergeyWh1te sergeyWh1te requested review from TheDZhon and removed request for vgorkavenko and dgusakov April 10, 2024 11:41
@sergeyWh1te sergeyWh1te force-pushed the linea-bridge-balance-mismatch branch from 8d97a55 to d0d9a93 Compare April 10, 2024 11:43
TheDZhon
TheDZhon previously approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 I'd suggest made a few name edits

l2-bridge-linea/src/clients/eth_provider_client.ts Outdated Show resolved Hide resolved
l2-bridge-linea/src/services/bridge_balance.ts Outdated Show resolved Hide resolved
l2-bridge-linea/src/clients/linea_provider.ts Outdated Show resolved Hide resolved
l2-bridge-linea/src/services/bridge_balance.ts Outdated Show resolved Hide resolved
TheDZhon
TheDZhon approved these changes Apr 10, 2024
View reviewed changes
Copy link
Contributor

@TheDZhon TheDZhon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@sergeyWh1te sergeyWh1te requested a review from a team April 10, 2024 12:48
@TheDZhon TheDZhon merged commit 999a602 into main Apr 10, 2024
5 checks passed
@TheDZhon TheDZhon deleted the linea-bridge-balance-mismatch branch April 10, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheDZhon TheDZhon TheDZhon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sergeyWh1te @TheDZhon