Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: more token to wallet response messages #545

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

manneredboor
Copy link
Contributor

Description

Displaying "Add tokens to wallet" regardless of wallet capability. Managing responses given from wallet by attempting of adding token.

Checklist:

  • Checked the changes locally.

@manneredboor manneredboor requested review from a team as code owners November 20, 2024 13:54
@preview-stands
Copy link

preview-stands bot commented Nov 20, 2024

Preview stand status

Preview stand available on testnet

if (
error?.code === -32602 // Trust
) {
ToastInfo('Tokens already existed');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already added

ToastError('The wallet does not support adding a token');
} else {
ToastError(
'An error occurred while adding token to wallet\nThe wallet probably does not support adding a token',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The wallet might not support

@Jeday
Copy link
Contributor

Jeday commented Nov 25, 2024

Generally, like this approach more, than pessimistically disabling this feature for users.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants