Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(@clayui/core):LPD 39956 Clay Table with nested rows shows expand button when children is empty array. #5884

Merged
merged 2 commits into from
Oct 31, 2024

Conversation

ilzamcmed
Copy link
Member

@ilzamcmed ilzamcmed commented Oct 30, 2024

jira ticket: https://liferay.atlassian.net/browse/LPD-39956

  • fix(@clayui/core): LPD-39956 - Not render left arrow button when child array is empty
  • fix(@clayui/core): LPD-39956 - Update tests

@ilzamcmed
Copy link
Member Author

Hey @matuzalemsteles @ethib137 @pat270
This PR is ready for review.

Thanks!

Copy link
Member

@matuzalemsteles matuzalemsteles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@matuzalemsteles matuzalemsteles merged commit ab72972 into liferay:master Oct 31, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants