Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect relative URL and missing fingerprint for bootstrap icons font #325

Open
bjowes opened this issue Aug 23, 2024 · 5 comments
Open

Comments

@bjowes
Copy link

bjowes commented Aug 23, 2024

Our project uses Bootstrap, which includes icon fonts imported through CSS. After a recent update of the WebOptimizer library, the reference to the fonts is incorrect so they are not loaded by the site.

Path to bootstrap CSS: /lib/bootstrap/dist/css/bootstrap.css
Path to font file: /lib/bootstrap/dist/fonts/glyphicons-halflings-regular.woff2
Path to bundle where bootstrap CSS is included: /css/bundle.css

The import line in bootstrap CSS for the font file: url("../fonts/glyphicons-halflings-regular.woff2")

WebOptimizer 3.0.420 renders this in the bundle (correct relative path and fingerprint):
url("../lib/bootstrap/dist/fonts/glyphicons-halflings-regular.woff2?v=93DUFX3R5ukJzB3V5fxFMdNdyXY")

WebOptimizer 3.0.422 (and up) renders this in the bundle (incorrect relative path, no fingerprint):
url("../../lib/bootstrap/dist/fonts/glyphicons-halflings-regular.woff2")

The only change between those versions was #320, so the new behavior was introduced there. I spent some time looking through the changes but I'm not familiar enough with the code base to identify the exact root cause.

We can roll back to 3.0.420 for now but I expect that others will bump into this issue too.

@daesk
Copy link

daesk commented Aug 23, 2024

I just noticed the same issue.
Will downgrade, but it would be nice if it would be fixed.

@nvirth
Copy link

nvirth commented Sep 3, 2024

Same here. Worked with 3.0.396, not working after upgrade to 3.0.426

@nabukhas
Copy link

Same happened to me, I had to downgrade to version 3.0.420 until it getting fixed in future version.
the issue exist in versions: 3.0.422 and 3.0.426

@emperador-ming
Copy link

Same here. We had to downgrade to version 3.0.420. The issue still persists in 3.0.422 & 3.0.426.

Elimi81 added a commit to Elimi81/WebOptimizer that referenced this issue Nov 4, 2024
@Elimi81
Copy link
Contributor

Elimi81 commented Nov 4, 2024

Tried to fix it, but my knowledge of the library is too limited I'm afraid. I found out that the commit bf09331 breaks something when it changes the RelativePathAdjuster. In Nuget if you use version before 3.0.422 everything still works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants