-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect relative URL and missing fingerprint for bootstrap icons font #325
Comments
I just noticed the same issue. |
Same here. Worked with |
Same happened to me, I had to downgrade to version 3.0.420 until it getting fixed in future version. |
Same here. We had to downgrade to version 3.0.420. The issue still persists in 3.0.422 & 3.0.426. |
…or resources inside css-files. (ligershark#325).
Tried to fix it, but my knowledge of the library is too limited I'm afraid. I found out that the commit bf09331 breaks something when it changes the RelativePathAdjuster. In Nuget if you use version before 3.0.422 everything still works. |
Our project uses Bootstrap, which includes icon fonts imported through CSS. After a recent update of the WebOptimizer library, the reference to the fonts is incorrect so they are not loaded by the site.
Path to bootstrap CSS:
/lib/bootstrap/dist/css/bootstrap.css
Path to font file:
/lib/bootstrap/dist/fonts/glyphicons-halflings-regular.woff2
Path to bundle where bootstrap CSS is included:
/css/bundle.css
The import line in bootstrap CSS for the font file:
url("../fonts/glyphicons-halflings-regular.woff2")
WebOptimizer 3.0.420 renders this in the bundle (correct relative path and fingerprint):
url("../lib/bootstrap/dist/fonts/glyphicons-halflings-regular.woff2?v=93DUFX3R5ukJzB3V5fxFMdNdyXY")
WebOptimizer 3.0.422 (and up) renders this in the bundle (incorrect relative path, no fingerprint):
url("../../lib/bootstrap/dist/fonts/glyphicons-halflings-regular.woff2")
The only change between those versions was #320, so the new behavior was introduced there. I spent some time looking through the changes but I'm not familiar enough with the code base to identify the exact root cause.
We can roll back to 3.0.420 for now but I expect that others will bump into this issue too.
The text was updated successfully, but these errors were encountered: