Fixes a bug that was introduced for relative urls #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…or resources inside css-files. (ligershark#325).
|
Ok, the tests need to be fixed also but I have so little knowledge of this project that I don't think i can do it properly atleast... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit bf09331 causes a bug in relative urls so that certain resources inside css-files are not referenced correctly. Fixes issue #325 reported by many. Though since I don't know the intent of the code in that commit, I cannot say why breaking "TrimStart" was added and does my change affect something else. Also there IS a problem with the test in RelativePathAdjusterTest.cs since it does not find this bug. The test passes with or without my commit and that should not be so. Some test is missing but I do not have enough knowledge to add missing tests.