Fix issue: in the called workflow, the github.event_name is that of t…

…he caller so it will never be workflow_call so we need to change to push

.github/workflows/base.yaml

@@ -20,8 +20,11 @@ jobs:
       - run: echo "Manually Called"
         if: ${{ github.event_name == 'workflow_dispatch' }}
 
-      - run: echo "Called from another workflow"
-        if: ${{ github.event_name == 'workflow_call' }}
+      # See https://github.com/actions/runner/issues/1548 for the fact that when called from
+      # another workflow, the github.event_name is the trigger for THAT caller workflow and
+      # not set to workflow_call!
+      - run: echo "Called from release workflow"
+        if: ${{ github.event_name == 'push' }}
 
       - uses: actions/checkout@v3
 

.github/workflows/moveit2.yaml

@@ -29,7 +29,7 @@ jobs:
 
       - name: Fetch prebuilt ROS2 base and Rviz2 from previous job artifacts
         uses: actions/download-artifact@v3
-        if: ${{ github.event_name == 'workflow_call' }}
+        if: ${{ github.event_name == 'push' }}
 
       - name: Extract artifacts
         run: ./extract_artifacts.sh

.github/workflows/release.yaml

@@ -1,6 +1,5 @@
 name: Build everything for release
 on:
-  workflow_dispatch:
   push:
     tags:
       - '**'

.github/workflows/rviz2.yaml

@@ -29,7 +29,7 @@ jobs:
 
       - name: Fetch prebuilt ROS2 base from previous job artifacts
         uses: actions/download-artifact@v3
-        if: ${{ github.event_name == 'workflow_call' }}
+        if: ${{ github.event_name == 'push' }}
 
       - name: Extract artifacts
         run: ./extract_artifacts.sh