feat: increase max receive message size #399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroper
commented
Aug 2, 2022
tck/package.json
Outdated
| @@ -11,7 +11,8 @@ | |||
| }, | |||
| "devDependencies": { | |||
| "testcontainers": "7.10.0", | |||
| "typescript": "4.3.4" | |||
| "typescript": "4.3.4", | |||
| "protobufjs": "6.11.3" | |||
There was a problem hiding this comment.
This was to work around #398 until we have a better solution.
jroper
force-pushed
the
increase-max-recv-msg-size
branch
from
be936f7 to
a58a095
Compare
jroper
force-pushed
the
increase-max-recv-msg-size
branch
from
a58a095 to
b4ec291
Compare
This increases the gRPC maximum receive message size to 12MB, and also makes both it and the max send size configurable.
octonato
force-pushed
the
increase-max-recv-msg-size
branch
from
b4ec291 to
1aa0f77
Compare
|
@jroper, I rebased this PR and did a push force. The goal is to merge and release it soon. |
|
Failed because of some documentation issue. I won't have time to check this. @jroper, could have a look? (watch-out, I did a force-push on your branch) |
|
That wasn't enough, the ChannelSettings interface needs to go in the exports in |
|
Added |
pvlugter
approved these changes
Aug 30, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This increases the gRPC maximum receive message size to 12MB, and also makes both it and the max send size configurable.