Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Lightly object detection input: Key error #12

Merged
merged 3 commits into from
Nov 15, 2023

Conversation

philippmwirth
Copy link
Contributor

@philippmwirth philippmwirth commented Nov 14, 2023

Closes #9.

  • Add LabelWithoutImageError.
  • Raise LabelWithoutImageError when LightlyObjectDetectionInput encounters a label without corresponding image.
  • Add --skip-labels-without-image flag.
  • Add unit tests.

Note that I didn't change Kitti because it works slightly different: The labels don't contain any reference to the original image so we can't iterate over the labels and retrieve the image filename because we can't guess the image type.

@philippmwirth philippmwirth marked this pull request as ready for review November 14, 2023 11:20
Copy link
Contributor

@michal-lightly michal-lightly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice, thanks for adding the tests!

src/labelformat/formats/lightly.py Show resolved Hide resolved
tests/unit/formats/test_lightly.py Outdated Show resolved Hide resolved
@philippmwirth philippmwirth merged commit 0641d09 into main Nov 15, 2023
2 checks passed
@philippmwirth philippmwirth deleted the philipp-skip-labels-without-image branch November 15, 2023 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lightly object detection input: Key error
2 participants