Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Faster image size extraction is #19

Merged
merged 5 commits into from
Dec 20, 2024
Merged

Faster image size extraction is #19

merged 5 commits into from
Dec 20, 2024

Conversation

IgorSusmelj
Copy link
Contributor

@IgorSusmelj IgorSusmelj commented Dec 14, 2024 •
edited
Loading

Changes

Builds up on PR #18 . Please only review once #18 is merged

  • implements tricks to extract the image width and height in a very efficient way
  • we only read the header info in jpg and png formats:
    • only the bytes that are required are read from disk
    • no image decoding
    • fallback to pillow in case the efficient approach does not work
  • added additional tests for the new functionality

@IgorSusmelj IgorSusmelj force-pushed the faster-image-size-extraction-is branch from c5dec93 to f1d5126 Compare December 19, 2024 21:32
ikondrat
ikondrat approved these changes Dec 20, 2024
View reviewed changes
Copy link

@ikondrat ikondrat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@IgorSusmelj IgorSusmelj merged commit d2f038a into main Dec 20, 2024
2 checks passed
@IgorSusmelj IgorSusmelj deleted the faster-image-size-extraction-is branch December 20, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ikondrat ikondrat ikondrat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@IgorSusmelj @ikondrat