holdinvoice

[daywalker90]

Adds a plugin to hold invoices aka hodlinvoices. For more info see https://github.com/daywalker90/holdinvoice#documentation

[cdecker]

Very nice 👍 Thanks for bearing with us @daywalker90, and sorry for the late move to the plugin repository

ACK e56f197

[cdecker]

Rebasing to get the CI running again.

[daywalker90]

I tihnk the CI is broken: ERROR: Package 'pyln-client' requires a different Python: 3.7.17 not in '<4.0,>=3.8'

[chrisguida]

Yep, it seems that the CI has issues with python dependencies, will dig more tomorrow.

Still familiarizing myself with this system...

[chrisguida]

@cdecker looks like DEVELOPER is gone, should we just remove it? Or replace it with DEBUGBUILD? Or we can just keep it as is, it seems to set DEBUGBUILD now: https://github.com/ElementsProject/lightning/blob/master/configure#L252

[chrisguida]

Also looks like we can remove testing on python 3.7 and add a few more recent versions, since pyln-client doesn't support 3.7 anymore

I'll put up a separate PR for a fix

[cdecker]

The DEVELOPER build-time flag is gone for good, replaced with the run-time flag --developer, so we can just remove any extra handling, or where needed use listconfigs to determine if we have the extended API available.

[chrisguida]

@daywalker90 I think this PR is next up, right? If so, please rebase on master and let's see if the tests pass

[chrisguida]

Actually let's try this

@Mergifyio rebase

[chrisguida]

@Mergifyio rebase

[mergify]

rebase

☑️ Nothing to do

• -conflict [📌 rebase requirement]
• -closed [📌 rebase requirement]

[chrisguida]

Hmm yeah looks like this needs a manual rebase @daywalker90

[daywalker90]

@daywalker90 I think this PR is next up, right? If so, please rebase on master and let's see if the tests pass

no imo, #486 -> #485 -> #487 -> then this

[chrisguida]

@daywalker90 SGTM

[daywalker90]

rebased and fixed tests for master

[chrisguida]

ACK 5e7988b

Looks great! Thanks for building this!! 🎉